kvserver: fix deadlock on rebalance obj change #97489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
kvoli
force-pushed
the
230222.fix-rebalance-deadlock
branch
2 times, most recently
from
5d9cfdb to
68e08f4
Compare
kvoli
force-pushed
the
230222.fix-rebalance-deadlock
branch
2 times, most recently
from
8f06d3a to
8658ab5
Compare
Previously, changing the rebalance objective could lead to inconsistent locking order between the load based splitter and rebalance objective. The split config is created per replica, rather than per store as it was previously. The split config and split decider are bundled underneath a new mutex which ensures consistent access. Resolves: cockroachdb#97000 Release note: None
kvoli
force-pushed
the
230222.fix-rebalance-deadlock
branch
from
8658ab5 to
ee624b8
Compare
|
closing in favor of #97539 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, changing the rebalance objective could lead to inconsistent
locking order between the load based splitter and rebalance objective.
The split config is created per replica, rather than per store as it was
previously. The split config and split decider are bundled underneath a
new mutex which ensures consistent access.
Resolves: #97000