Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.2: sql: disallow UDF in SET DEFAULT and SET ON UPDATE #97430

Merged
merged 1 commit into from
Feb 22, 2023
Merged

release-22.2: sql: disallow UDF in SET DEFAULT and SET ON UPDATE #97430

merged 1 commit into from
Feb 22, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Feb 21, 2023 •
edited by chengxiong-ruan
Loading

Backport 1/1 commits from #97390 on behalf of @chengxiong-ruan.

/cc @cockroachdb/release

Epic: None.

Release note (sql change): previously users were able to sneak in UDF usage from tables with SET DEFAULT and SET ON UPDATE even they are disallowed from CREATE TABLE and ADD COLUMN. This patch disallows those two cases from ALTER TABLE ALTER COLUMN.

Release justification: low risk but necessary feature flagging.

@blathers-crl blathers-crl bot requested a review from a team February 21, 2023 23:32
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-97390 branch from 9fb31a0 to 15e0179 Compare February 21, 2023 23:32
@blathers-crl blathers-crl bot requested a review from Xiang-Gu February 21, 2023 23:32
@blathers-crl
Copy link
Author

blathers-crl bot commented Feb 21, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Feb 21, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@chengxiong-ruan
sql: disallow UDF in SET DEFAULT and SET ON UPDATE
7a6af51 
Release note (sql change): previously users were able to sneak
in UDF usage from tables with `SET DEFAULT` and `SET ON UPDATE`
even they are disallowed from `CREATE TABLE` and `ADD COLUMN`.
This patch disallows those two cases from `ALTER TABLE ALTER COLUMN`.
@chengxiong-ruan chengxiong-ruan force-pushed the blathers/backport-release-22.2-97390 branch from 15e0179 to 7a6af51 Compare February 22, 2023 19:07
@chengxiong-ruan chengxiong-ruan merged commit c1fa140 into release-22.2 Feb 22, 2023
@chengxiong-ruan chengxiong-ruan deleted the blathers/backport-release-22.2-97390 branch February 22, 2023 21:20
@cockroach-teamcity cockroach-teamcity mentioned this pull request Feb 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chengxiong-ruan chengxiong-ruan chengxiong-ruan approved these changes

@Xiang-Gu Xiang-Gu Awaiting requested review from Xiang-Gu

Assignees

@chengxiong-ruan chengxiong-ruan

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cockroach-teamcity @chengxiong-ruan