parser: add QUERY to bare_label_keyword
#97041
Conversation
|
It looks like your PR touches SQL parser code but doesn't add or edit parser tests. Please make sure you add or edit parser tests if you edit the parser. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
ZhouXing19
force-pushed
the
add-query-keyword
branch
from
4c73330 to
9814778
Compare
| @@ -16374,6 +16374,7 @@ bare_label_keywords: | |||
| | INVOKER | |||
| | LEAKPROOF | |||
| | PARALLEL | |||
| | QUERY | |||
There was a problem hiding this comment.
we discussed offline, but could you adjust the comment a bit for bare_label_keywords and the other rules above and below? i think the information is a bit outdated.
There was a problem hiding this comment.
I just chatted with @chengxiong-ruan and have it updated. Basically we still want a keyword to be only in one of those "_keyword" lists (note, bare_labeled_keywords is not one of them), but newly added keyword should always be added to bare_labeled_keywords as well.
As revealed by cockroachdb#84309, some keywords not added to `bare_label_keywords` in `sql.y` will make the `SELECT ... <keyword>` statement error out, which is not compatible with postgres. This commit is to add the `QUERY` keyword per a support ticket. We're not adding the whole `unreserved_keyword` list here as having some of them in `bare_label_keyword`, such as `DAY`, bring `reduce` errors. Postgres: ``` postgres=# select substring('stringstringstring',1,10) query; query ------------ stringstri (1 row) ``` CRDB: ``` root@localhost:26257/defaultdb> select substring('stringstringstring',1,10) query; invalid syntax: statement ignored: at or near "query": syntax error SQLSTATE: 42601 DETAIL: source SQL: select substring('stringstringstring',1,10) query ^ ``` informs cockroachdb#84309 Release Note(bug fix): fixed the syntax error for `SELECT ... QUERY` (without AS) statement.
ZhouXing19
force-pushed
the
add-query-keyword
branch
from
9814778 to
db011d3
Compare
|
Failed test in the CI is irrelevant. Thanks! bors r+ |
|
Build succeeded: |
As revealed by #84309, some keywords not added to
bare_label_keywordsinsql.ymake theSELECT ... <keyword>statement error out, which is not compatible with postgres. This commit is to add theQUERYkeyword per a support ticket. We're not adding the wholeunreserved_keywordlist here as having some of them inbare_label_keyword, such asDAY, bringsreduceerrors.Postgres:
CRDB:
informs #84309
Release Note(bug fix): fixed the syntax error for
SELECT ... QUERY(without AS) statement.