glide.yaml: update grpc

[tamird]

This update includes 118 commits.

grpc/grpc-go@79b7c34...777daa1

Interesting PRs:

• Client side interceptors:
  Support client side interceptor grpc/grpc-go#867
• Stricter error handling:
  Close headerChan if processHeaderField sets error grpc/grpc-go#876
• More robust cancellation:
  Move balancer initialization into a goroutine grpc/grpc-go#882
• Fix context leak:
  Use user context instead of creating new context for client side stream grpc/grpc-go#891
• Client load balancing:
  Add the basic support of grpclb grpc/grpc-go#899
• Fix quota miscounting:
  Use the correct error in defer call grpc/grpc-go#947

Also updates gogo/protobuf to pick up
gogo/protobuf@8d70fb3 which is required due
to the grpc.SupportPackageIsVersion mechanism.

---

This change is

[tbg]

LGTM, but let's line this up into the queue of "potentially critical PRs" and roll it out alone.

[tbg]

@petermattis we need at least a tiny bit of infrastructure for these PRs. Should we create a label to that end?

[petermattis]

Agree that we should sequence the merging of this PR. A label sounds good. Care to bikeshed a name?

[tbg]

Let's use stability for now.

[bdarnell]

LGTM

[tamird]

Updated.

[tamird]

beta is cut, merging.

[petermattis]

Review status: 0 of 13 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

---

pkg/kv/transport.go, line 166 at r1 (raw file):

	gt.setPending(client.args.Replica, true)

	batchFn := func(ctx context.Context, args *roachpb.BatchRequest) (*roachpb.BatchResponse, error) {

Somehow this part of the change escaped my notice. Seems like purely cleanup that is unrelated to the grpc upgrade. I'm not sure if this is more readable. If you wanted to avoid the multiple go calls, we could have moved the localServer lookup inside of the single go call.

---

Comments from Reviewable

[tamird]

Would you like me to send a follow up?

…

On Dec 20, 2016 10:48 AM, "Peter Mattis" ***@***.***> wrote: Review status: 0 of 13 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful. ------------------------------ *pkg/kv/transport.go, line 166 at r1 <https://reviewable.io:443/reviews/cockroachdb/cockroach/9697#-KZRpTtK4luhkcoo0yBb:-KZRpTtK4luhkcoo0yBc:b-s8tezy> (raw file <https://github.com/cockroachdb/cockroach/blob/cf371771bbff0de57b8776973d76a6aad6426f39/pkg/kv/transport.go#L166>):* gt.setPending(client.args.Replica, true) batchFn := func(ctx context.Context, args *roachpb.BatchRequest) (*roachpb.BatchResponse, error) { Somehow this part of the change escaped my notice. Seems like purely cleanup that is unrelated to the grpc upgrade. I'm not sure if this is more readable. If you wanted to avoid the multiple go calls, we could have moved the localServer lookup inside of the single go call. ------------------------------ *Comments from Reviewable <https://reviewable.io:443/reviews/cockroachdb/cockroach/9697>* — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#9697 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABdsPOnyS45I1Qc-KKa13mNfDR4lrC83ks5rJ_iqgaJpZM4KNKmY> .

[petermattis]

Would you like me to send a follow up?

Yes.