collatedstring: support default, C, and POSIX in expressions #96828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the small amount of code from tree/collatedstring.go Release note: None
|
This change is |
rafiss
changed the title
rafiss
force-pushed
the
collate-default-alias
branch
from
095263e to
4bdb998
Compare
otan
reviewed
Feb 8, 2023
There was a problem hiding this comment.
two broader questions:
- does
pg_catalog.pg_collationneed an update? - should we add a linter that prevents usage of
collate.Supported()? can useas inspo.cockroach/pkg/testutils/lint/lint_test.go
Line 729 in 1b79102
| // modified. | ||
| const PosixCollationTag = "POSIX" | ||
|
|
||
| var supportedTagNames []string |
There was a problem hiding this comment.
should we use language.Tag here?
There was a problem hiding this comment.
hmm, maybe we can't because language.Tag has metadata in it. oh well!
There was a problem hiding this comment.
yeah i had tried to get it to work with Tag, but it can't. there's no way to even make a "custom" Tag.
rafiss
force-pushed
the
collate-default-alias
branch
from
4bdb998 to
b8a80ca
Compare
that's done as part of this
added |
otan
approved these changes
Feb 8, 2023
Release note (sql change): Expressions of the form `COLLATE "default"`, `COLLATE "C"`, and `COLLATE "POSIX"` are now supported. Since the default collation cannot be changed currently, these expressions are all equivalent. The expressions are evaluated by treating the input as a normal string, and ignoring the collation. This means that comparisons between strings and collated strings that use "default", "C", or "POSIX" are now supported. Creating a column with the "C" or "POSIX" collations is still not supported.
rafiss
force-pushed
the
collate-default-alias
branch
from
b8a80ca to
a7e9c4a
Compare
|
tftr! bors r=otan |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #50734
fixes #95667
informs #57255
collatedstring: create new package
Move the small amount of code from tree/collatedstring.go
collatedstring: support C and POSIX in expressions
Release note (sql change): Expressions of the form
COLLATE "default",COLLATE "C", andCOLLATE "POSIX"are now supported. Since thedefault collation cannot be changed currently, these expressions are all
equivalent. The expressions are evaluated by treating the input as a
normal string, and ignoring the collation.
This means that comparisons between strings and collated strings that
use "default", "C", or "POSIX" are now supported.
Creating a column with the "C" or "POSIX" collations is still not
supported.