batcheval: enforce lease proposed ts #96785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
tbg
force-pushed
the
always-prop-ts
branch
2 times, most recently
from
2d1a849 to
fd98de1
Compare
pav-kv
approved these changes
Feb 14, 2023
|
bors r=pavelkalinnikov |
|
Build failed: |
Epic: none Release note: None
The test wasn't verifying anything about Gossip already anyway. It got in my way (proposing with nil `ProposedTS`) so might as well remove it now. Epic: none Release note: None
This is already true in practice. Epic: none Release note: None
|
bors r=pavelkalinnikov |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is always set, except in some tests. Now these tests set it, too.
Release note: None
Epic: None