Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: ctx fixes #9661

Merged
merged 2 commits into from
Oct 1, 2016
Merged

Conversation

RaduBerinde
Copy link
Member

@RaduBerinde RaduBerinde commented Oct 1, 2016

This change is Reviewable

@tamird
Copy link
Contributor

tamird commented Oct 1, 2016

:lgtm:


Reviewed 1 of 1 files at r1, 6 of 6 files at r2.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

@tamird
Copy link
Contributor

tamird commented Oct 1, 2016

master?

@RaduBerinde RaduBerinde changed the base branch from develop to master October 1, 2016 15:13
@petermattis
Copy link
Collaborator

:lgtm:


Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.


storage/replica.go, line 492 at r2 (raw file):

  // Add replica log tag - the value is rangeStr.String().
  r.ctx = log.WithLogTag(store.Ctx(), "r", &r.rangeStr)

Nice. On a handful of occasions I ran into the irritation of trying to use Replica.ctx before it was initialized.


Comments from Reviewable

@RaduBerinde RaduBerinde merged commit 38005f6 into cockroachdb:master Oct 1, 2016
@RaduBerinde RaduBerinde deleted the storage-ctx-fixes branch October 1, 2016 19:44
@jseldess jseldess mentioned this pull request Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants