build: speed up go generate: don't run ui tests #9639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, go generate would not only generate all of the protobufs and embedded.go, but also run the ui linters and tests. This is pretty slow and not really relevant to go generate. Now, go generate only generates files. CI has been updated to run the ui tests if necessary.
jordanlewis
force-pushed
the
fast-go-generate
branch
from
d7213c5 to
7d62eab
Compare
|
LGTM |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, go generate would not only generate all of the protobufs and
embedded.go, but also run the ui linters and tests. This is pretty slow
and not really relevant to go generate.
Now, go generate only generates files. CI has been updated to run the ui
tests if necessary.
This change is