sql: add new keywords to bare_label_keyword list #95985
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds all the new keywords added in 23.1 as of this commit to the
bare labels list:
CAPABILITIES
CAPABILITY
DETAILS
EXTREMES
INVISIBLE
RETENTION
TENANT_NAME
TENANTS
INDEX_AFTER_ORDER_BY_BEFORE_AT
INDEX_BEFORE_NAME_THEN_PAREN
INDEX_BEFORE_PAREN
NOTHING_AFTER_RETURNING
Note that `INDEX` and `NOTHING` moved from a reserved keyword to an
unreserved keyword, but I didn't include it here so that this commit
only adds the new keywords in 23.1.
Epic: None
Release note: None
|
It looks like your PR touches SQL parser code but doesn't add or edit parser tests. Please make sure you add or edit parser tests if you edit the parser. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
|
Once bors gets around to merging #95691 I'll update this PR with the remaining keywords and some tests. |
|
Fixed more completely in #97878 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds all the new keywords added in 23.1 as of this commit to the bare labels list:
Note that
INDEXandNOTHINGmoved from a reserved keyword to an unreserved keyword, but I didn't include it here so that this commit only adds the new keywords in 23.1.Epic: None
Release note: None