release-22.2: sql: improve stack trace for get-user-timeout timeouts #95890
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #95797 on behalf of @ecwall.
/cc @cockroachdb/release
Fixes #95794
The cause of the
get-user-timeout
errors is unknown. Part of the problem is that the stack trace gets cut off atwhich does not explain what is actually being blocked.
The reason that the stack trace is cut off is that the timeout is initiated by
contextutil.RunWithTimeout
which results in a "simple" (no stack trace)context.DeadlineExceeded
error.retrieveSessionInitInfoWithCache
is the first line in the stack trace because it callserrors.Wrap
oncontext.DeadlineExceeded
.To get a fuller stack trace,
context.DeadlineExceeded
must be wrapped immediately (errors.Wrap
orerrors.WithStack
) before it bubbles up.Release note: None
Release justification: