Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc: fix comment #95559

Merged
merged 1 commit into from
Jan 20, 2023
Merged

rpc: fix comment #95559

merged 1 commit into from
Jan 20, 2023

Conversation

andreimatei
Copy link
Contributor

This copy-pasta comment was mentioning a KV node, which was not right.

Release note: None
Epic: None

@andreimatei
rpc: fix comment
74d45b7 
This copy-pasta comment was mentioning a KV node, which was not right.

Release note: None
Epic: None
@andreimatei andreimatei requested a review from knz January 19, 2023 22:48
@andreimatei andreimatei requested review from a team as code owners January 19, 2023 22:49
@blathers-crl
Copy link

blathers-crl bot commented Jan 19, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

knz
knz approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers

andreimatei
andreimatei commented Jan 20, 2023
View reviewed changes
Copy link
Contributor Author

@andreimatei andreimatei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained

@craig craig bot merged commit 1b79102 into cockroachdb:master Jan 20, 2023
@craig
Copy link
Contributor

craig bot commented Jan 20, 2023

Build succeeded:

@andreimatei andreimatei deleted the small.auth-comment branch January 21, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knz knz knz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreimatei @cockroach-teamcity @knz