multitenant: append WITH REPLICATION STATUS columns to SHOW TENANT columns
#95526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
…` columns Informs #87851 `WITH CAPABILITIES` will be adding another set of columns so append relevant columns instead of creating all possible column sets ahead of time. Release note: None
ecwall
commented
Jan 19, 2023
| node.columns = colinfo.TenantColumnsWithReplication | ||
| } else { | ||
| node.columns = colinfo.TenantColumns | ||
| node.columns = append(node.columns, colinfo.TenantColumnsWithReplication...) | ||
| } | ||
|
|
There was a problem hiding this comment.
The capabilities PR will add
if n.WithCapabilities {
node.columns = append(node.columns, colinfo.TenantColumnsWithCapabilities...)
}
| } | ||
|
|
There was a problem hiding this comment.
The capabilities PR will add
if n.WithCapabilities {
result = append(result, ...)
}
knz
approved these changes
Jan 19, 2023
There was a problem hiding this comment.
Nice.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @arulajmani and @rafiss)
|
bors r=knz |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs #87851
WITH CAPABILITIESwill be adding another set of columns so append relevant columns instead of creating all possible column sets ahead of time.Release note: None