Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: separate loadstats cpu nanos to raft/req #95387

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

kvoli
Copy link
Collaborator

@kvoli kvoli commented Jan 17, 2023

Previously, loadstats tracked replica raft/request cpu nanos per second separately but returned both summed together in load.ReplicaLoadStats. This patch separates RaftCPUNanosPerSecond and
RequestCPUNanosPerSecond in the returned load.ReplicaLoadStats so that they may be used independently.

Informs #95380

Release note: None

Previously, loadstats tracked replica raft/request cpu nanos per second
separately but returned both summed together in `load.ReplicaLoadStats`.
This patch separates `RaftCPUNanosPerSecond` and
`RequestCPUNanosPerSecond` in the returned `load.ReplicaLoadStats` so
that they may be used independently.

Informs cockroachdb#95380

Release note: None
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@kvoli kvoli marked this pull request as ready for review January 17, 2023 20:20
@kvoli kvoli requested a review from a team as a code owner January 17, 2023 20:20
@kvoli kvoli requested a review from andrewbaptist January 17, 2023 20:20
@kvoli kvoli self-assigned this Jan 17, 2023
Copy link
Collaborator

@andrewbaptist andrewbaptist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kvoli
Copy link
Collaborator Author

kvoli commented Jan 20, 2023

TYFTR!

bors r=andrewbaptist

@craig
Copy link
Contributor

craig bot commented Jan 20, 2023

Build failed (retrying...):

@craig craig bot merged commit 1b79102 into cockroachdb:master Jan 20, 2023
@craig
Copy link
Contributor

craig bot commented Jan 20, 2023

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants