sql: fix the pretty-printing of the PARTITION BY clauses #95272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
otan
approved these changes
Jan 16, 2023
| --- | ||
|
|
||
| # Check that the result of pretty-printing quotes the identifiers | ||
| # in the parittion list and the partition names properly. |
The AST was incorrectly using tree.UnrestrictedName, whereas the PARTITION BY clauses could use special identifiers. Release note: None
knz
force-pushed
the
20230115-partition-syntax
branch
from
49eaea0 to
67b0933
Compare
|
TFYR! bors r=otan |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #95238.
The AST was incorrectly using tree.UnrestrictedName, whereas the PARTITION BY clauses could use special identifiers.
Release note: None