Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql/importer: Fix BenchmarkConvertToKVs #95054

Merged

Conversation

herkolategan
Copy link
Collaborator

Set cluster.MakeTestingClusterSettings() in eval.Context Settings for BenchmarkConvertToKVs to execute successfully.

Fixes: #95052

Release justification: test-only change.
Release note: None

Set `cluster.MakeTestingClusterSettings()` in `eval.Context` Settings for
`BenchmarkConvertToKVs` to execute successfully.

Fixes: cockroachdb#95052

Release justification: test-only change.
Release note: None
@herkolategan herkolategan requested a review from a team January 11, 2023 12:03
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@herkolategan herkolategan merged commit ec92c4e into cockroachdb:master Jan 12, 2023
@herkolategan herkolategan deleted the hbl/benchmark-convert-to-kvs-fix branch January 12, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql/importer: BenchmarkConvertToKVs panics
3 participants