kvserver: check lease rebalance target exists in cached storelist #94723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
From cockroachdb#91593 it was possible for a new lease target to have its store descriptor dereferenced despite not existing in a list of candidate stores earlier. This patch resolves the dereference. fixes: cockroachdb#94688 Release note: None
kvoli
force-pushed
the
230104.sr-descriptor-deref
branch
from
94ea6ef to
39e86ad
Compare
erikgrinaker
approved these changes
Jan 4, 2023
|
TYFTR bors r=erikgrinaker |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #91593 it was possible for a new lease target to have its store descriptor dereferenced despite not existing in a list of candidate stores earlier.
This patch resolves the dereference.
fixes: #94688
Release note: None