pkg/ui: Swap in new Snapshot debug component #94701
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @andreimatei and @benbardin)
pkg/ui/workspaces/cluster-ui/src/tracez/snapshot/snapshotPage.tsx line 326 at r1 (raw file):
], [nodeID, snapshotID, spanID, spanOperation], );
is useMemo necessary here? the operation doesn't look expensive.
pkg/ui/workspaces/cluster-ui/src/tracez/snapshot/snapshotPage.tsx line 341 at r1 (raw file):
// eslint-disable-next-line react-hooks/exhaustive-deps [nodeID, snapshotID, spanID, spanOperation], );
same comment as above.
Part of: cockroachdb#83679 Release note: None
There was a problem hiding this comment.
Reviewable status:
pkg/ui/workspaces/cluster-ui/src/tracez/snapshot/snapshotPage.tsx line 326 at r1 (raw file):
Previously, dhartunian (David Hartunian) wrote…
is
useMemonecessary here? the operation doesn't look expensive.
Done.
pkg/ui/workspaces/cluster-ui/src/tracez/snapshot/snapshotPage.tsx line 341 at r1 (raw file):
Previously, dhartunian (David Hartunian) wrote…
same comment as above.
Done.
There was a problem hiding this comment.
Reviewable status:
|
bors r+ |
|
This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried. |
94701: pkg/ui: Swap in new Snapshot debug component r=benbardin a=benbardin The PR focuses on the routes. I'll delete deprecated code in a follow-up diff. Part of: #83679 Release note: None Co-authored-by: Ben Bardin <[email protected]>
|
bors r- |
|
Canceled. |
The PR focuses on the routes. I'll delete deprecated code in a follow-up diff.
Part of: #83679
Release note: None