kvserver: account for replica follower write bytes #94444
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
erikgrinaker
approved these changes
Jan 4, 2023
erikgrinaker
reviewed
Jan 4, 2023
Previously, only bytes written at the leaseholder were accounted for on a replica. Now, follower replicas will record the bytes written. Informs: cockroachdb#91152 Release note: None
kvoli
force-pushed
the
221229.correct-replica-write-bytes
branch
from
8cefe53 to
a0604b7
Compare
|
We should still tackle this. The patch is stale, closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only bytes written at the leaseholder were accounted for on a replica. Now, follower replicas will record the bytes written.
Informs: #91152
Release note: None