Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

streamingccl: don't resume job in TestTenantStreamingCutoverOnSourceFailure #94180

Merged
merged 1 commit into from
Jan 25, 2023
Merged

streamingccl: don't resume job in TestTenantStreamingCutoverOnSourceFailure #94180

merged 1 commit into from
Jan 25, 2023

Conversation

stevendanna
Copy link
Collaborator

@stevendanna stevendanna commented Dec 22, 2022 •
edited
Loading 

ALTER TENANT ... COMPLETE REPLICATION

resumes the job for the user, so there is no need to resume the job here. This does raise the question about whether or not it is the right behaviour to resume the job by default.

Fixes #94034

Release note: None

@stevendanna
streamingccl: don't resume job in TestTenantStreamingCutoverOnSourceF…
9e84744 
…ailure

    ALTER TENANT ... COMPLETE REPLICATION

resumes the job for the user, so there is no need to resume the job
here. This does raise the question about whether or not it is the
right behaviour to resume the job by default.

Fixes cockroachdb#94034

Release note: None
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@stevendanna stevendanna changed the title streamingccl: don't resume job in TestTenantStreamingCutoverOnSourceF… streamingccl: don't resume job in TestTenantStreamingCutoverOnSourceFailure Dec 22, 2022
@stevendanna stevendanna requested a review from dt December 22, 2022 20:05
@adityamaru
Copy link
Contributor

imo it is the correct behavior for a COMPLETE REPLICATION query to kick things into motion to do just that. We run maybeRevertToCutoverTimestamp at the top of the Resume hook and so we are resuming the replication job for the purposes of cutting over if the timestamp is before our replicated time. If the user does specify a timestamp we have not replicated until then they are hopefully doing that knowingly, in which case starting up the replication feed shouldn't come as a surprise.

@stevendanna
Copy link
Collaborator Author

bors r=adityamaru

@craig
Copy link
Contributor

craig bot commented Jan 25, 2023

Build failed:

@stevendanna
Copy link
Collaborator Author

bors retry

@craig craig bot merged commit 6fc1022 into cockroachdb:master Jan 25, 2023
@craig
Copy link
Contributor

craig bot commented Jan 25, 2023

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityamaru adityamaru adityamaru approved these changes

@dt dt Awaiting requested review from dt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ccl/streamingccl/streamingest: TestTenantStreamingCutoverOnSourceFailure failed
3 participants
@stevendanna @cockroach-teamcity @adityamaru