catenumpb: extract new package for enum protobufs #94160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit extracts a new package `catenumpb` that is intended to contain enum protobufs so that the new package is very low dependency and could be imported everywhere. The following things are moved into the new package: - `catpb/index.proto` (while keeping the protobuf path at `catpb`) - non-protobuf `IndexDescriptorEncodingType` is moved from `descpb` - `descpb/encoded_datum.proto`. Epic: None Release note: None
yuzefovich
requested review from
msbutler and
cucaroach
and removed request for
a team
|
This change is |
yuzefovich
requested review from
Xiang-Gu
and removed request for
a team,
msbutler and
cucaroach
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit extracts a new package
catenumpbthat is intended to contain enum protobufs so that the new package is very low dependency and could be imported everywhere. The following things are moved into the new package:catpb/index.proto(while keeping the protobuf path atcatpb)IndexDescriptorEncodingTypeis moved fromdescpbdescpb/encoded_datum.proto.Epic: CRDB-14837
Release note: None