storage: return error from {MVCC,Engine}Iterator.Value #94025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumeerbhola
requested review from
msbutler and
msirek
and removed request for
a team
|
This change is |
sumeerbhola
force-pushed
the
value_err
branch
from
e8b2cc7 to
f6082d6
Compare
Informs cockroachdb/pebble#1170 Epic: CRDB-20378 Release note: None
sumeerbhola
force-pushed
the
value_err
branch
from
f6082d6 to
a269b14
Compare
nicktrav
approved these changes
Dec 21, 2022
There was a problem hiding this comment.
Reviewed 24 of 24 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @itsbilal, @jbowens, and @msbutler)
|
TFTRs! |
|
bors r=mgartner,nicktrav |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs cockroachdb/pebble#1170
Epic: CRDB-20378
Release note: None