Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.2: sql: Define more columns in pg_catalog.pg_statistic_ext #94009

Merged
merged 1 commit into from
Dec 21, 2022
Merged

release-22.2: sql: Define more columns in pg_catalog.pg_statistic_ext #94009

merged 1 commit into from
Dec 21, 2022

Conversation

e-mbrown
Copy link
Contributor

@e-mbrown e-mbrown commented Dec 20, 2022 •
edited
Loading

Backport 1/1 commits from #93274.

/cc @cockroachdb/release

Fixes: #88108
Fixes: #93430

This commit makes sure the stxnamespace, stxkind and stxstattarget columns are defined in pg_statistics_ext.

Release note: The stxnamespace, stxkind and
stxstattarget columns are now defined in
pg_statistics_ext. Also pg_statistics_ext
no longer crashes when stxname is null.

Release justification: Bug fix

@e-mbrown e-mbrown requested review from rafiss and a team December 20, 2022 21:45
@blathers-crl
Copy link

blathers-crl bot commented Dec 20, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

rafiss
rafiss requested changes Dec 20, 2022
View reviewed changes
Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but a change is needed for the backport

pkg/sql/pg_catalog.go Outdated Show resolved Hide resolved
@e-mbrown
sql: Define more columns in pg_catalog.pg_statistic_ext
e6ff222 
`pg_catalog.pg_statistic_ext` is now
populated with more data.

Release note (bug fix): The `stxnamespace`, `stxkind` and
`stxstattarget` columns are now defined in
`pg_statistics_ext`.
@e-mbrown e-mbrown requested a review from rafiss December 21, 2022 14:56
@rafiss rafiss merged commit 403654c into cockroachdb:release-22.2 Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafiss rafiss rafiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@e-mbrown @cockroach-teamcity @rafiss