Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: collapse these if statements #93921

Merged
merged 2 commits into from
Dec 19, 2022
Merged

ui: collapse these if statements #93921

merged 2 commits into from
Dec 19, 2022

Conversation

matthewtodd
Copy link
Contributor

Epic: None
Release note: None

@matthewtodd
ui: refresh nodes on tenants
8bfa82a 
Part of #89949

Now that we can show meaningful region information for tenants, we need
to actually trigger the fetching of that information.

Release note: None
@matthewtodd
ui: collapse these if statements
97cc327 
Epic: None
Release note: None
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@matthewtodd matthewtodd mentioned this pull request Dec 19, 2022
Merged
@matthewtodd
Copy link
Contributor Author

Thanks, @xinhaoz!

bors r+

@matthewtodd matthewtodd marked this pull request as ready for review December 19, 2022 20:15
@matthewtodd matthewtodd requested a review from a team December 19, 2022 20:15
@craig
Copy link
Contributor

craig bot commented Dec 19, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Dec 19, 2022

Build succeeded:

@craig craig bot merged commit 61f7c81 into cockroachdb:master Dec 19, 2022
@matthewtodd matthewtodd deleted the collapse-ifs branch December 19, 2022 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xinhaoz xinhaoz xinhaoz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewtodd @cockroach-teamcity @xinhaoz