Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: upgrade grpc to v1.51.0 #93867

Merged
merged 1 commit into from
Dec 19, 2022
Merged

Conversation

erikgrinaker
Copy link
Contributor

@erikgrinaker erikgrinaker commented Dec 18, 2022

This upgrade contains a number of bugfixes, including crasher bugs.

A previous upgrade to v1.49.0 had to be rolled back because of kv/splits/nodes=3 roachtest failures. This no longer fails with v1.51.0.

Resolves #81227.
Touches #88745.

Epic: none
Release note: None

This upgrade contains a number of bugfixes, including crashes bugs.

A previous upgrade to v1.49.0 had to be rolled back because of
`kv/splits/nodes=3` roachtest failures. This no longer fails with
v1.51.0.

Epic: none
Release note: None
@erikgrinaker erikgrinaker requested review from knz, tbg and a team December 18, 2022 20:00
@erikgrinaker erikgrinaker requested a review from a team as a code owner December 18, 2022 20:00
@erikgrinaker erikgrinaker self-assigned this Dec 18, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@tbg
Copy link
Member

tbg commented Dec 19, 2022

Are we picking up anything interesting? I pulled up grpc/grpc-go@v1.46.0...v1.51.0 but it's too granular to really review.

@erikgrinaker
Copy link
Contributor Author

erikgrinaker commented Dec 19, 2022

Release notes are here: https://github.com/grpc/grpc-go/releases

A couple of race condition/deadlock fixes, but otherwise nothing really stood out.

CI failure is unrelated.

bors r+

@craig
Copy link
Contributor

craig bot commented Dec 19, 2022

Build succeeded:

@craig craig bot merged commit 1b1c848 into cockroachdb:master Dec 19, 2022
@knz
Copy link
Contributor

knz commented Dec 19, 2022

@adityamaru this is ready for your team now.

@adityamaru
Copy link
Contributor

Thank you! cc: @rhu713 this should unblock the 503 Google SDK diff if I remember correctly.

@erikgrinaker erikgrinaker deleted the grpc-upgrade branch December 28, 2022 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kvserver: v21.2.7: nil pointer in gRPC transport when sending snapshots
6 participants