Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: refactor doctor #93732

Merged
merged 1 commit into from
Dec 19, 2022
Merged

dev: refactor doctor #93732

merged 1 commit into from
Dec 19, 2022

Conversation

rickystewart
Copy link
Collaborator

Create a new interactive dev doctor experience, so you don't have to copy-paste commands from dev doctor and it can solve problems for you.

Now dev doctor will be interactive by default and will ask for user input to confirm the actions it's going to take. You can also set --autofix to automatically agree to some default actions without having to interactive. Interactive doctor can be disabled with --interactive=false.

Epic: none
Release note: None

@rickystewart rickystewart requested a review from a team as a code owner December 15, 2022 19:48
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rickystewart
Copy link
Collaborator Author

Here's what the output can look like:

DOCTOR >> Do you want to use the `lintonbuild` configuration? [y] > YES
DOCTOR >> Please set a tmpdir that will be used for storing test artifacts [/tmp/cockroach] > 
======================================
=== FINISHED RUNNING DOCTOR CHECKS ===
======================================
You are ready to build :)

@rickystewart
dev: refactor doctor
f68c87e 
Create a new interactive `dev doctor` experience, so you don't have to
copy-paste commands from `dev doctor` and it can solve problems for you.

Now `dev doctor` will be interactive by default and will ask for user
input to confirm the actions it's going to take. You can also set
`--autofix` to automatically agree to some default actions without
having to interactive. Interactive doctor can be disabled with
`--interactive=false`.

Epic: none
Release note: None
healthy-pod
healthy-pod approved these changes Dec 17, 2022
View reviewed changes
Copy link
Contributor

@healthy-pod healthy-pod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@rickystewart
Copy link
Collaborator Author

bors r=healthy-pod

@craig
Copy link
Contributor

craig bot commented Dec 19, 2022

Build succeeded:

@craig craig bot merged commit 91fbbad into cockroachdb:master Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@healthy-pod healthy-pod healthy-pod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rickystewart @cockroach-teamcity @healthy-pod