server,jobs: remove the logic to run the scheduler on 1 node #93639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
miretskiy
approved these changes
Dec 14, 2022
knz
force-pushed
the
20221214-job-sched
branch
2 times, most recently
from
3bb61f2 to
1800911
Compare
|
TFYR! bors r=miretskiy |
|
Build failed: |
- The mechanism to limit the scheduler execution to 1 node was only effective on KV nodes, with direct access to the leaseholder information for the liveness table. However, we want uniform behavior in a multitenant environment, so a mechanism specific to KV nodes is not acceptable any more. - Since this was first implemented, we've found the job scheduler not to be disruptive any more, so it's now safe to run it on every node. Release note: None
knz
force-pushed
the
20221214-job-sched
branch
from
1800911 to
388dee7
Compare
|
bors r=miretskiy |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90383.
The mechanism to limit the scheduler execution to 1 node was only effective on KV nodes, with direct access to the leaseholder information for the liveness table.
However, we want uniform behavior in a multitenant environment, so a mechanism specific to KV nodes is not acceptable any more.
Since this was first implemented, we've found the job scheduler not to be disruptive any more, so it's now safe to run it on every node.
Release note: None