storage: remove time-based ExportRequest resource limiter #93323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First 3 commits are from another PR. |
|
This change is |
sumeerbhola
approved these changes
Dec 9, 2022
There was a problem hiding this comment.
Reviewed 7 of 7 files at r4, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained
stevendanna
force-pushed
the
remove-resource-limiter
branch
2 times, most recently
from
58d5534 to
cfa6103
Compare
stevendanna
force-pushed
the
remove-resource-limiter
branch
from
cfa6103 to
8acd2b8
Compare
This resource limiter was disabled by default and competes with the enabled-by-default elastic CPU limiter. Removing it simplifies the code a bit with very little downside. Epic: None Release note: None
stevendanna
force-pushed
the
remove-resource-limiter
branch
from
8acd2b8 to
e843b64
Compare
|
bors r=sumeerbhola |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resource limiter was disabled by default and competes with the
enabled-by-default elastic CPU limiter. Removing it simplifies the
code a bit with very little downside.
Epic: None
Release note: None