Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: add go scheduling latency graph to Overload dashboard #93217

Merged
merged 1 commit into from
Dec 8, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,26 @@ export default function (props: GraphDashboardProps) {
</Axis>
</LineGraph>,

<LineGraph
title="Goroutine Scheduling Latency: 99th percentile"
sources={nodeSources}
tooltip={`P99 scheduling latency for goroutines`}
>
<Axis units={AxisUnits.Duration} label="latency">
{nodeIDs.map(nid => (
<>
<Metric
key={nid}
name="cr.node.go.scheduler_latency-p99"
title={nodeDisplayName(nodeDisplayNameByID, nid)}
sources={[nid]}
downsampleMax
/>
</>
))}
</Axis>
</LineGraph>,

<LineGraph
title="Runnable Goroutines per CPU"
sources={nodeSources}
Expand Down Expand Up @@ -213,7 +233,7 @@ export default function (props: GraphDashboardProps) {
</LineGraph>,

<LineGraph title="Admission Delay: 75th percentile" sources={nodeSources}>
<Axis label="delay for requests that waited (nanos)">
<Axis units={AxisUnits.Duration} label="delay for requests that waited">
{nodeIDs.map(nid => (
<>
<Metric
Expand Down