-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql, clusterversion: add new index usage column on system.statement_statistics #93089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryliag
force-pushed
the
idx-idx-usage
branch
2 times, most recently
from
December 7, 2022 00:45
5b63600
to
8c15b96
Compare
maryliag
changed the title
sql, clusterversion: add new index on system.statement_statistics
sql, clusterversion: add new index usage column on system.statement_statistics
Dec 7, 2022
maryliag
force-pushed
the
idx-idx-usage
branch
4 times, most recently
from
December 7, 2022 19:19
e8e16f9
to
ac9a0a4
Compare
maryliag
force-pushed
the
idx-idx-usage
branch
3 times, most recently
from
December 20, 2022 20:54
683bcc9
to
13121c1
Compare
maryliag
force-pushed
the
idx-idx-usage
branch
from
December 20, 2022 21:05
13121c1
to
da4d119
Compare
postamar
approved these changes
Dec 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this if CI's happy.
pkg/upgrade/upgrades/alter_statement_statistics_index_recommendations_test.go
Outdated
Show resolved
Hide resolved
maryliag
force-pushed
the
idx-idx-usage
branch
3 times, most recently
from
December 21, 2022 16:33
f4b54fb
to
1bdb3de
Compare
…tatistics This commits adds a new index `indexes_usage` virtual column on value `(statistics-> 'statistics'-> 'indexes')` with respective `indexes_usage_idx` index on `system.statement_statistics` table. Part Of cockroachdb#93087 Release note (sql change): Add column `indexes_usage` and index `indexes_usage_idx` on value on table `system.statement_statistics`.
maryliag
force-pushed
the
idx-idx-usage
branch
from
December 21, 2022 18:05
1bdb3de
to
6c6ee65
Compare
TFTR! |
Build failed (retrying...): |
Build failed (retrying...): |
Build failed (retrying...): |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits adds a new index
indexes_usage
virtual column on value(statistics-> 'statistics'-> 'indexes')
with respectiveindexes_usage_idx
index on
system.statement_statistics
table.Part Of #93087
Performance Tests:
YCSB Workload
TPC C Workload
Release note (sql change): Add column
indexes_usage
and indexindexes_usage_idx
on value on table
system.statement_statistics
.