Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql, clusterversion: add new index usage column on system.statement_statistics #93089

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

maryliag
Copy link
Contributor

@maryliag maryliag commented Dec 5, 2022

This commits adds a new index indexes_usage virtual column on value
(statistics-> 'statistics'-> 'indexes') with respective indexes_usage_idx
index on system.statement_statistics table.

Part Of #93087

Performance Tests:

YCSB Workload

branch elapsed errors ops(total) ops/sec(cum) avg(ms) p50(ms) p95(ms) p99(ms) pMax(ms)
main 1860.0s 0 37623701 20227.8 1.0 0.8 2.5 4.5 134.2
idx 1860.0s 0 44831436 24102.9 0.8 0.7 2.1 3.7 352.3

TPC C Workload

branch elapsed tpmC efc avg(ms) p50(ms) p90(ms) p95(ms) p99(ms) pMax(ms)
main 1860.0s 12.4 96.3% 29.8 29.4 35.7 39.8 44.0 46.1
idx 1860.0s 12.3 95.3% 28.0 28.3 37.7 39.8 46.1 52.4

Release note (sql change): Add column indexes_usage and index indexes_usage_idx
on value on table system.statement_statistics.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@maryliag maryliag force-pushed the idx-idx-usage branch 2 times, most recently from 5b63600 to 8c15b96 Compare December 7, 2022 00:45
@maryliag maryliag changed the title sql, clusterversion: add new index on system.statement_statistics sql, clusterversion: add new index usage column on system.statement_statistics Dec 7, 2022
@maryliag maryliag force-pushed the idx-idx-usage branch 4 times, most recently from e8e16f9 to ac9a0a4 Compare December 7, 2022 19:19
@maryliag maryliag force-pushed the idx-idx-usage branch 3 times, most recently from 683bcc9 to 13121c1 Compare December 20, 2022 20:54
@maryliag maryliag requested a review from a team December 20, 2022 20:54
@maryliag maryliag marked this pull request as ready for review December 20, 2022 20:54
@maryliag maryliag requested a review from a team December 20, 2022 20:54
Copy link
Contributor

@postamar postamar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this if CI's happy.

pkg/upgrade/upgrades/upgrades.go Outdated Show resolved Hide resolved
@maryliag maryliag force-pushed the idx-idx-usage branch 3 times, most recently from f4b54fb to 1bdb3de Compare December 21, 2022 16:33
…tatistics

This commits adds a new index `indexes_usage` virtual column on value
`(statistics-> 'statistics'-> 'indexes')` with respective `indexes_usage_idx`
index on `system.statement_statistics` table.

Part Of cockroachdb#93087

Release note (sql change): Add column `indexes_usage` and index
 `indexes_usage_idx` on value on table `system.statement_statistics`.
@maryliag
Copy link
Contributor Author

TFTR!
bors r+

@craig
Copy link
Contributor

craig bot commented Dec 21, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Dec 21, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Dec 22, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Dec 22, 2022

Build succeeded:

@craig craig bot merged commit a210d60 into cockroachdb:master Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants