backupccl: deflake multinode datadriven tests that set cluster settings #92911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
msbutler
commented
Dec 2, 2022
| @@ -87,6 +87,10 @@ type sqlDBKey struct { | |||
| } | |||
|
|
|||
| type datadrivenTestState struct { | |||
| // clusters maps a name to its cluster | |||
| clusters map[string]serverutils.TestClusterInterface | |||
There was a problem hiding this comment.
I wonder if we ought to change the new-server cmd to new-cluster, as it's really spinning up a new cluster and pushing all sql cmds to get served by the first server in the test cluster.
There was a problem hiding this comment.
just pushed an extra commit for this.
adityamaru
approved these changes
Dec 4, 2022
The `SET CLUSTER SETTING` stmt propogrates the cluster setting to remote nodes asynchronously, but our data driven multinode tests incorrectly assumed that settings were propogated during stmt execution. This patch adds a new 'set-cluster-setting' dd cmd which will propogate the cluster setting to all nodes before the cmd returns. Fixes cockroachdb#92808 Release note: none
Previously, whenever the dd driver worked with a test cluster, it was always called a server instead of a cluster. This is confusing, given all the other ways crdb uses the word "server". To clear the air, this patch replaces all uses of the word "server" with "cluster", where appropriate. Epic: none Release note: None
msbutler
force-pushed
the
butler-cluster-settings
branch
from
ebf217c to
5102486
Compare
msbutler
changed the title
|
TFTR! bors r=adityamaru |
|
Build succeeded: |
This was referenced Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SET CLUSTER SETTINGstmt propogrates the cluster setting to remote nodes asynchronously, but our data driven multinode tests incorrectly assumed that settings were propogated during stmt execution. This patch adds a new 'set-cluster-setting' dd cmd which will propogate the cluster setting to all nodes before the cmd returns.Fixes #92808
Release note: none