Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.1: sql: fix attidentity for GENERATED BY DEFAULT AS IDENTITY column #92835

Merged
merged 1 commit into from
Dec 2, 2022
Merged

release-22.1: sql: fix attidentity for GENERATED BY DEFAULT AS IDENTITY column #92835

merged 1 commit into from
Dec 2, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Dec 1, 2022 •
edited by ZhouXing19
Loading

Backport 1/1 commits from #92545 on behalf of @ZhouXing19.

/cc @cockroachdb/release

It should be d rather than b in this case.

Release note (bug fix): attidentity in pg_attribute for GENERATED BY DEFAULT AS IDENTITY column should be d.

Epic: None

Release justification: small bug fix

@ZhouXing19
sql: fix attidentity for GENERATED BY DEFAULT AS IDENTITY column
816e856 
It should be `d` rather than `b` in this case.

Release note (bug fix): attidentity for `GENERATED BY DEFAULT AS IDENTITY`
column should be `d`.

<what was there before: Previously, ...>
<why it needed to change: This was inadequate because ...>
<what you did about it: To address this, this patch ...>
@blathers-crl blathers-crl bot requested a review from a team December 1, 2022 16:45
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.1-92545 branch from 84f3ca0 to 816e856 Compare December 1, 2022 16:45
@blathers-crl
Copy link
Author

blathers-crl bot commented Dec 1, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested a review from rafiss December 1, 2022 16:45
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Dec 1, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss merged commit 67fc4b6 into release-22.1 Dec 2, 2022
@rafiss rafiss deleted the blathers/backport-release-22.1-92545 branch December 2, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafiss rafiss rafiss approved these changes

Assignees

@ZhouXing19 ZhouXing19

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @rafiss @ZhouXing19