sql: DROP TENANT makes name reclaimable #92076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
ajwerner
approved these changes
Nov 17, 2022
I assume you mean something more than: perhaps something that actually starts a new sql pod against this tenant and does some work? |
ajwerner
approved these changes
Nov 17, 2022
lidorcarmel
approved these changes
Nov 17, 2022
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @stevendanna)
Previously, you couldn't reuse a tenant name until GC completed. This makes the name immediately reclaimable, saving the old name in droppedName in case we need it for something. Note that with the virtual column this only works because ->> returns NULL for the empty string. Release note: None
stevendanna
force-pushed
the
reclaim-tenant-name
branch
from
cb0ccf9 to
cf0b2de
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, you couldn't reuse a tenant name until GC completed. This makes the name immediately reclaimable, saving the old name in droppedName in case we need it for something.
Note that with the virtual column this only works because ->> returns NULL for the empty string.
Epic: None
Release note: None