Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.1: admission: temporary knob to disable AC for user requests #91928

Merged

Conversation

andrewbaptist
Copy link
Collaborator

@andrewbaptist andrewbaptist commented Nov 15, 2022

Backport 1/1 commits from #90448.

/cc @cockroachdb/release


informs: #85641

Only leave admission control in place for elastic / bulk requests.

Release note: None

Release justification: This adds a configurable flag that can help us in cases where a large job (like index creation) is affecting user traffic. Testing on TPC-E index creation has shown long delays to user traffic (2 minutes) without this setting. There are plans to address this in v23.1, however, until then this is a "last resort" lever for those types of customers.

@blathers-crl
Copy link

blathers-crl bot commented Nov 15, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@andrewbaptist andrewbaptist marked this pull request as ready for review November 15, 2022 18:34
@andrewbaptist andrewbaptist requested a review from a team as a code owner November 15, 2022 18:34
@cockroach-teamcity
Copy link
Member

This change is Reviewable

informs: cockroachdb#85641

Temporary knob to allow disabling admission control for non-elastic /
bulk requests.

Release note: None
@andrewbaptist andrewbaptist merged commit 771d1b6 into cockroachdb:release-22.1 Nov 15, 2022
@andrewbaptist andrewbaptist deleted the backport22.1-90448 branch November 15, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants