roachtest/mixed-versions-compat: use corpus for master #91458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
fqazi
force-pushed
the
mixedVersionNumber
branch
from
f73f790 to
e707f27
Compare
ajwerner
approved these changes
Nov 8, 2022
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @fqazi)
|
@ajwerner I'm going to bors this to have the test functional again, but we do have a compatibility issue between master and 22.2 in the mixed version state (which is planning related) |
|
bors r+ |
|
Build failed (retrying...): |
|
bors r- |
|
Canceled. |
fqazi
force-pushed
the
mixedVersionNumber
branch
from
e707f27 to
2c2cbff
Compare
fqazi
requested review from
smg260 and
renatolabs
and removed request for
a team
Fixes: cockroachdb#91350 The CI build scripts take advantage of the branch name to uplaod the corpus to GCS. Unfortunately, we have no way of know if the current build is master inside the roachtest. To address this, this patch supports fetching the master corpus as a fallback. Release note: None
fqazi
force-pushed
the
mixedVersionNumber
branch
from
2c2cbff to
137e0c0
Compare
|
bors r+ |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs: #91350
The CI build scripts take advantage of the branch name to uplaod the corpus to GCS. Unfortunately, we have no way of know if the current build is master inside the roachtest. To address this, this patch supports fetching the master corpus as a fallback.
Release note: None