tracing: use timeutil for Now() and Since() #91289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Am I missing something here for why we're using the local time in this one spot? |
andreimatei
approved these changes
Nov 4, 2022
There was a problem hiding this comment.
Am I missing something here for why we're using the local time in this one spot?
I think there used to be a significant performance penalty for using timeutil.Now in Since calculations before f782e45
Please run the benchmarks in the tracing package to see if they say anything.
And remove the tracer.go linter exception from lint_test.go. There's crdbspan.go in there too, because it uses time.Since(); I think it can use timeutil.Since() and also be removed from the exemptions.
Reviewable status:
complete! 1 of 0 LGTMs obtained
yuzefovich
force-pushed
the
tracing-utc-start-time
branch
from
b016757 to
9047185
Compare
Previously, for performance reasons (as well as a few others) we used `time.Now()` and `time.Since` in the tracing library. But the work in f782e45 alleviated those concerns, so we can now switch to using `timeutil` library in two places. ``` Tracer_StartSpanCtx/opts=none-24 508ns ± 0% 512ns ± 0% +0.80% (p=0.000 n=10+10) Tracer_StartSpanCtx/opts=real-24 510ns ± 1% 515ns ± 1% +0.96% (p=0.000 n=10+10) Tracer_StartSpanCtx/opts=real,logtag-24 539ns ± 1% 544ns ± 1% +0.90% (p=0.000 n=10+10) Tracer_StartSpanCtx/opts=real,autoparent-24 480ns ± 0% 486ns ± 1% +1.26% (p=0.000 n=10+10) Tracer_StartSpanCtx/opts=real,manualparent-24 523ns ± 1% 527ns ± 1% +0.91% (p=0.004 n=10+10) Tracer_StartSpanCtx/opts=real,autoparent,withEventListener-24 755ns ± 0% 765ns ± 0% +1.40% (p=0.000 n=10+10) Tracer_StartSpanCtx/opts=real,manualparent,withEventListener-24 547ns ± 1% 552ns ± 1% +0.89% (p=0.000 n=10+10) Span_GetRecording/root-only-24 7.36ns ± 0% 6.75ns ± 0% -8.26% (p=0.000 n=10+10) Span_GetRecording/child-only-24 7.36ns ± 0% 6.75ns ± 0% -8.30% (p=0.000 n=10+10) Span_GetRecording/root-child-24 7.36ns ± 0% 6.74ns ± 0% -8.32% (p=0.000 n=10+10) RecordingWithStructuredEvent/with-event-listener-24 3.47µs ± 1% 3.47µs ± 1% ~ (p=0.541 n=10+10) RecordingWithStructuredEvent/without-event-listener-24 3.31µs ± 0% 3.32µs ± 1% ~ (p=0.271 n=10+10) SpanCreation/detached-child=false-24 1.07µs ± 1% 1.07µs ± 1% ~ (p=0.955 n=10+10) SpanCreation/detached-child=true-24 1.84µs ± 1% 1.82µs ± 1% -1.30% (p=0.000 n=10+10) ``` And no changes in allocations. Epic: None Release note: None
yuzefovich
force-pushed
the
tracing-utc-start-time
branch
from
9047185 to
ab51513
Compare
yuzefovich
changed the title
|
TFTR! The benchmarks didn't show changes: |
|
WDYT about backporting to 22.2? |
|
bors r+ |
|
Build succeeded: |
Where did non-UTC timestamps show up exactly? (you seem to have deleted this from the commit msg for some reason :P ) |
|
I probably just never mentioned that - the way I got here was by trying to determine the time when a particular stmt bundle was collected, so I found |
|
That's not reason enough for a backport IMO. |
|
Ack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, for performance reasons (as well as a few others) we used
time.Now()andtime.Sincein the tracing library. But the work inf782e45 alleviated those concerns, so
we can now switch to using
timeutillibrary in two places.And no changes in allocations.
Epic: None
Release note: None