ui: simplify insights sagas, fix contention query filter #90784
Conversation
|
This change is |
ericharmeling
force-pushed
the
insights-cluster-ui-store-fixes
branch
from
78aed76 to
b5ef2a2
Compare
There was a problem hiding this comment.
since you closed #88830, you can update the PR description with the unblock on it
Nice work, glad to see it is working! I added a comment on the video, not sure if was related to your changes, but looks like the column selector didn't work. You can address this on this PR or on a following one.
Otherwise,
Reviewed 14 of 14 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @ericharmeling)
… selector This commit simplifies the insights sagas by moving the insights store refresh interval to the components and removing the root-level reset saga. The commit also updates the SQL query for the transaction contention events to not JOIN with the internal insights table, and to filter out all unresolved txn fingerprint IDs. The commit also properly handles the case in which no columns are selected. Fixes cockroachdb#90142. Release note: None
ericharmeling
force-pushed
the
insights-cluster-ui-store-fixes
branch
from
b5ef2a2 to
9bb0af5
Compare
There was a problem hiding this comment.
you can update the PR description with the unblock on it
Done
I added a comment on the video, not sure if was related to your changes, but looks like the column selector didn't work. You can address this on this PR or on a following one.
Good catch! The column selector was hooked up, but there was a bug in how the column selection was stored. In the case in which all columns were unselected, the selection was stored as null, which resulted in the column selection showing the default columns. Fixed!
Here's a loom: https://www.loom.com/share/8857b4a22f2c4a129d58e315dc18f6c7
Reviewable status:
There was a problem hiding this comment.
Thanks for fixing that too!
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:
|
bors r+ |
|
Build failed: |
|
bors retry |
|
Build succeeded: |
This PR simplifies the insights sagas by moving the insights store refresh interval to the components and removing the root-level reset saga. The commit also updates the SQL query for the transaction contention events to not JOIN with the internal insights table, and to filter out all unresolved txn fingerprint IDs.
Fixes #90142.
Release note: None
Loom: https://www.loom.com/share/f12685c712124560b326f211b44a06d1