-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: use longer-lived context for purgeOldSessions #90693
server: use longer-lived context for purgeOldSessions #90693
Conversation
It looks like, the async task start by startPurgeOldSessions outlived the span on the context that it was being passed. Here, we pass it an annotated background context. Fixes cockroachdb#90692 Epic: None Release note: None
Meant to open this as a draft, this is untested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
edit I was wrong |
@knz Looks like your PR covers this and more. If you want to fold in the change to tenant.go into your PR (assuming it is correct), we could just merge yours and close this. |
Release note: None
Release note: None
@knz I pushed another commit that changes other uses of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cheers
This hit some CI issues so I couldn't merge it before going offline yesterday. It looks like most of these fixes got merged in other PRs. We'll just need to remember to echo some of those fixes in any backport. I think the makePlanner thing still needs to be fixed. I'll open a PR for that. |
It looks like, the async task start by startPurgeOldSessions outlived the span on the context that it was being passed. Here, we pass it an annotated background context.
Fixes #90692
Epic: None
Release note: None