release-22.2: server: write pebble log messages to storage channel #90650
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #90478 on behalf of @renatolabs.
/cc @cockroachdb/release
Previously, when setting up the server, the pebble engine would be initialized with Pebble's default logger. The reason for this is that the pebble initialization code calls
EnsureDefaults
on the configuration options before checking if theoptions.Logger
is nil/unset. At that point, it will never be unset, asEnsureDefaults
will set the logger topebble.DefaultLogger
if it was not previously set.This change overwrites the pebble logger if its found to be the
DefaultLogger
. We never want to use pebble'sDefaultLogger
in CRDB as that would mean pebble would use the standard librarylog
package, making every message emitted by Pebble to be treated asINFO
level messages, regardless of severity (includinglog.Fatal
calls).Related to #83079.
Fixes #72683.
Fixes #90483.
Release note: None.
Release justification: fixes a bug where pebble crashes could occur without any error messages being logged.