Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.1: server: start purging web_sessions in secondary tenants #90635

Closed

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Oct 25, 2022

Backport 2/2 commits from #90523 on behalf of @knz.

/cc @cockroachdb/release


Fixes #90522.

The next PR #90384 will ensure this code lands in the right place.


Release justification: avoid resource leak

@blathers-crl blathers-crl bot requested a review from a team as a code owner October 25, 2022 17:33
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.1-90523 branch from 2321766 to 07ff98e Compare October 25, 2022 17:33
@blathers-crl blathers-crl bot requested review from aadityasondhi, stevendanna and a team October 25, 2022 17:33
@blathers-crl
Copy link
Author

blathers-crl bot commented Oct 25, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Oct 25, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@stevendanna stevendanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same reminder that we probably want to make sure we are using the correct context for these two calls.

@knz
Copy link
Contributor

knz commented Oct 28, 2022

i'll replace this with a backport of #90789.

@knz knz closed this Oct 28, 2022
@mgartner mgartner deleted the blathers/backport-release-22.1-90523 branch May 23, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants