Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: correct tooltip message for circuit breaker events chart #90604

Merged

Conversation

koorosh
Copy link
Collaborator

@koorosh koorosh commented Oct 25, 2022

This patch corrects the message on circuit breaker events chart to highlight that the chart displays the total number of events per aggregated interval of time instead of "per second".

Release note: None

Epic: none

@koorosh koorosh requested review from zachlite and a team October 25, 2022 10:48
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@koorosh koorosh force-pushed the ui-fix-circuit-breaker-events-tooltip branch 2 times, most recently from bdb7bed to f04deee Compare November 1, 2022 14:04
Copy link
Contributor

@Santamaura Santamaura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @zachlite)

@koorosh
Copy link
Collaborator Author

koorosh commented Nov 7, 2022

bors r+

@craig
Copy link
Contributor

craig bot commented Nov 7, 2022

🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@craig
Copy link
Contributor

craig bot commented Nov 7, 2022

GitHub status checks took too long to complete, so bors is giving up. You can adjust bors configuration to have it wait longer if you like.

@koorosh
Copy link
Collaborator Author

koorosh commented Nov 8, 2022

bors r+

@craig
Copy link
Contributor

craig bot commented Nov 8, 2022

🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

This patch corrects the message on circuit breaker events
chart to highlight that the chart displays the total number
of events per aggregated interval of time instead of "per second".

Release note: None
@koorosh koorosh force-pushed the ui-fix-circuit-breaker-events-tooltip branch from f04deee to 8ecac97 Compare November 9, 2022 13:03
@koorosh
Copy link
Collaborator Author

koorosh commented Nov 9, 2022

bors r+

@craig
Copy link
Contributor

craig bot commented Nov 9, 2022

Build succeeded:

@craig craig bot merged commit 3642ac4 into cockroachdb:master Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants