cluster-ui: add explain plan tab for statement insights #90250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
xinhaoz
force-pushed
the
insights-explain-plan
branch
2 times, most recently
from
fcafdd9 to
d5a78b3
Compare
xinhaoz
changed the title
xinhaoz
changed the title
matthewtodd
approved these changes
Oct 19, 2022
This commit refactors the statement insight details page component from a class component to a functional component. Release note: None
Closes cockroachdb#88093 This commit adds a new tab to the statement insight details page. The page is now separated into two tabs: 1. Overview - what was already on the page (insights details) 2. Explain Plan - the explain plan for the stmt being viewed Release note (ui change): new tab view added to the stmt insight details page: 1. Overview - what was already on the page (insights details) 2. Explain Plan - the explain plan for the stmt being viewed
xinhaoz
force-pushed
the
insights-explain-plan
branch
from
d5a78b3 to
fe1d3bd
Compare
|
TFTR! |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from a7dc5ed to blathers/backport-release-22.2-90250: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
This was referenced Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 1
This commit refactors the statement insight details page
component from a class component to a functional component.
Release note: None
Commit 2
cluster-ui: add explain plan tab for statement insights
Closes #88093
This commit adds a new tab to the statement insight details
page. The page is now separated into two tabs:
Release note (ui change): new tab view added to the stmt insight
details page: