sql: turn plan sampling back off by default #89847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
matthewtodd
approved these changes
Oct 12, 2022
There was a problem hiding this comment.
LGTM. Build failure looks like whitespace differences in docs/generated/settings/settings.html:
diff --git a/docs/generated/settings/settings.html b/docs/generated/settings/settings.html
index 8d28ec9f38..6620036f6b 100644
--- a/docs/generated/settings/settings.html
+++ b/docs/generated/settings/settings.html
@@ -187,12 +187,7 @@
<tr><td><code>sql.metrics.statement_details.gateway_node.enabled</code></td><td>boolean</td><td><code>true</code></td><td>save the gateway node for each statement fingerprint. If false, the value will be stored as 0.</td></tr>
<tr><td><code>sql.metrics.statement_details.index_recommendation_collection.enabled</code></td><td>boolean</td><td><code>true</code></td><td>generate an index recommendation for each fingerprint ID</td></tr>
<tr><td><code>sql.metrics.statement_details.max_mem_reported_idx_recommendations</code></td><td>integer</td><td><code>5000</code></td><td>the maximum number of reported index recommendation info stored in memory</td></tr>
-<tr>
- <td><code>sql.metrics.statement_details.plan_collection.enabled</code></td>
- <td>boolean</td>
- <td><code>false</code></td>
- <td>periodically save a logical plan for each fingerprint</td>
-</tr>
+<tr><td><code>sql.metrics.statement_details.plan_collection.enabled</code></td><td>boolean</td><td><code>false</code></td><td>periodically save a logical plan for each fingerprint</td></tr>
|
Fixed, I didn't realize that GoLand reformatted the line. |
|
bors r+ |
|
Build failed (retrying...): |
|
Build succeeded: |
j82w
pushed a commit
that referenced
this pull request
Oct 18, 2022
This value was enabled by default again: #89020. The reason it was enabled again was fixed in #89418. Part of #89847 Release justification: Bug fixes and low-risk updates to new functionality. Release note (sql change): Turn the default value of sql.metrics.statement_details.plan_collection.enabled to false.
j82w
pushed a commit
that referenced
this pull request
Nov 2, 2022
This value was enabled by default again: #89020. The reason it was enabled again was fixed in #89418. Part of #89847 Release justification: Bug fixes and low-risk updates to new functionality. Release note (sql change): Turn the default value of sql.metrics.statement_details.plan_collection.enabled to false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value was originally disabled by default in: #88343. The value was enabled by default: #89020 because of a bug that was fixed in #89418. This PR is disabling it by default again now that the bug has been fixed.
Part Of #89847
Release note (sql change): Turn the default value of sql.metrics.statement_details.plan_collection.enabled to false.