Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: fix logic test option typos #89781

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

mgartner
Copy link
Collaborator

This commit fixes a few tests that incorrectly separated test options with a space instead of a comma.

Release note: None

@mgartner mgartner requested review from DrewKimball and a team October 11, 2022 21:04
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@michae2 michae2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball)

@mgartner mgartner force-pushed the fix-logic-test-typos branch from 673f4b3 to f1046ec Compare October 12, 2022 19:09
This commit fixes a few tests that incorrectly separated test options
with a space instead of a comma.

Release note: None
@mgartner mgartner force-pushed the fix-logic-test-typos branch from f1046ec to 7276a22 Compare October 13, 2022 16:33
@mgartner
Copy link
Collaborator Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Oct 13, 2022

Build succeeded:

@craig craig bot merged commit c09bc70 into cockroachdb:master Oct 13, 2022
@mgartner mgartner deleted the fix-logic-test-typos branch October 13, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants