scop, scdep: Rename IndexValidator to Validator
#89662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This PR renames `IndexValidator` in package `scexec` to `Validator` because we are going to enable it to validate a check constraint in the next few commits.
Xiang-Gu
force-pushed
the
rename-IndexValidator-to-Validator
branch
from
b082e96 to
239786a
Compare
ajwerner
approved these changes
Oct 10, 2022
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 13 of 13 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @Xiang-Gu)
|
Thanks for the quick review! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've recently done work to enable adding/dropping check constraints in the declarative
schema changer. It is a big PR with many commits. I think it's nicer to separate them
further into multiple PRs.
This is the first PR in that effort, which is merely renaming and should be easy to review:
commit 1: ValidateCheckConstraint now uses ConstraintID, instead of constraint name;
commit 2: Rename
IndexValidatortoValidator.We previously had a file under scdep called
index_validator.gowhere we implementlogic for validating an index. Now that we are going to validate a check constraint, we
renamed them so they will also validate check constraints.
Informs #89665
Release note: None