Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: skip roachtests needing old releases on ARM64 #89210

Merged
merged 1 commit into from
Oct 4, 2022
Merged

roachtest: skip roachtests needing old releases on ARM64 #89210

merged 1 commit into from
Oct 4, 2022

Conversation

healthy-pod
Copy link
Contributor

@healthy-pod healthy-pod commented Oct 3, 2022 •
edited
Loading

This code change skips some roachtests on ARM64 because
we do not have enough ARM64 releases to run them.

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@healthy-pod healthy-pod requested a review from renatolabs October 3, 2022 18:00
@renatolabs
Copy link
Contributor

Unfortunately, a lot more tests would fail; you can search for the callers of PredecessorVersion for example and you'll see.

Would also be nice to create an issue for us to enable them on the next release and link that issue in the Skip call.

roachtest: skip roachtests needing old releases on ARM64
ee061dd 
This code change skips some roachtests on ARM64 because
we do not have enough ARM64 releases to run them.

Release note: None
@healthy-pod healthy-pod force-pushed the skip-version-upgrade branch from ac16ef9 to ee061dd Compare October 4, 2022 07:06
@healthy-pod
Copy link
Contributor Author

Unfortunately, a lot more tests would fail; you can search for the callers of PredecessorVersion for example and you'll see.

Would also be nice to create an issue for us to enable them on the next release and link that issue in the Skip call.

I skipped tests that depend on PredecessorVersion and created this issue to track re-enabling them.

renatolabs
renatolabs approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@renatolabs renatolabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@healthy-pod healthy-pod changed the title roachtest: skip version-upgrade on ARM64 roachtest: skip roachtests needing old releases on ARM64 Oct 4, 2022
@healthy-pod
Copy link
Contributor Author

TFTR!

bors r=renatolabs

@craig
Copy link
Contributor

craig bot commented Oct 4, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Oct 4, 2022

Build succeeded:

@craig craig bot merged commit 7098b09 into cockroachdb:master Oct 4, 2022
@healthy-pod
Copy link
Contributor Author

blathers backport release-22.2

@blathers-crl blathers-crl bot mentioned this pull request Oct 11, 2022
Merged
@healthy-pod
Copy link
Contributor Author

blathers backport release-22.2.0

@blathers-crl blathers-crl bot mentioned this pull request Oct 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatolabs renatolabs renatolabs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@healthy-pod @cockroach-teamcity @renatolabs