changefeedccl: verify changefeed failure for reverted import #89169
+53
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
miretskiy
approved these changes
Oct 3, 2022
| sqlDB.Exec(t, "INSERT INTO for_import VALUES (0, 10);") | ||
|
|
||
| // Start an import job which will immediately pause after ingestion | ||
| sqlDB.Exec(t, "SET CLUSTER SETTING jobs.debug.pausepoints = 'import.after_ingest';") |
There was a problem hiding this comment.
Nice (@dt would be trilled to see this).
samiskin
commented
Oct 3, 2022
| cdcTestNamed(t, "reverted import fails changefeed with earlier cursor", func(t *testing.T, s TestServer, f cdctest.TestFeedFactory) { | ||
| sqlDB := sqlutils.MakeSQLRunner(s.DB) | ||
| sqlDB.Exec(t, "SET CLUSTER SETTING kv.bulk_io_write.small_write_size = '1';") | ||
| sqlDB.Exec(t, "SET CLUSTER SETTING storage.mvcc.range_tombstones.enabled = true;") |
There was a problem hiding this comment.
@miretskiy I assume the ConstantWithMetamorphicTestBool on the cluster setting is something that applies to every test, so I'm wary of making a change like that here just for this test.
samiskin
force-pushed
the
changefeed-tombstone-ignore-test
branch
2 times, most recently
from
0dd0569 to
f27f1f9
Compare
Resolves cockroachdb#82943 A new test verifies that even if an import was reverted the changefeed still fails on a table offline error. This is now needed to ensure we don't have undesired behavior during a case where rangefeeds would emit range tombstones. Release note: None
samiskin
force-pushed
the
changefeed-tombstone-ignore-test
branch
from
f27f1f9 to
29ce5b1
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #82943
A new test verifies that even if an import was reverted the changefeed still fails on a table offline error. This is now needed to ensure we don't have undesired behavior during a case where rangefeeds would emit range tombstones.
Release note: None