Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: sql: turn plan sampling back on by default #89038

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

maryliag
Copy link
Contributor

@maryliag maryliag commented Sep 29, 2022

Backport 1/1 commits from #89020.

/cc @cockroachdb/release


This value was disabled by default on #88343
but brought visibility to a bug of statements not being properly trace when they should be on the first time. Since we might not be able to finish the proper fix before the cut on backports, I'm turning back on and a following commit can turn this back off and add the fix for the problem.

Release note (sql change): Turn the default value of sql.metrics.statement_details.plan_collection.enabled to true


Release justification: turning value back on, because being false was causing a bug

This value was disabled by default on cockroachdb#88343
but brought visibility to a bug of statements not being properly
trace when they should be on the first time. Since
we might not be able to finish the proper fix before the
cut on backports, I'm turning back on and a following commit
can turn this back off and add the fix for the problem.

Release note (sql change): Turn the default value of
`sql.metrics.statement_details.plan_collection.enabled` to `true`
@maryliag maryliag requested a review from a team September 29, 2022 22:09
@blathers-crl
Copy link

blathers-crl bot commented Sep 29, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@maryliag maryliag merged commit 797d13e into cockroachdb:release-22.2 Sep 29, 2022
@maryliag maryliag deleted the backport22.2-89020 branch September 29, 2022 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants