roachtest: run clearrange test with range tombstones #88735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
aliher1911
force-pushed
the
clear_range_range_tombstone_gc
branch
from
2cc0f1d to
00962cc
Compare
|
I'm seeing the desired behaviour and elevated performance impact caused by clear range. This is because GC hint (#88336) is not merged. It should go back to being similar to what was there before after this pr is rebased on top of the change. |
|
Needs backport as we will converge to a single version once range tombstones become default, but this release will benefit from having two dedicated tests. |
Previously clear range tests were run with default server settings. Range tombstones are disabled by default so new functionality in schema change commands is not execised. This commit adds test variant that enables range tombstones. Release note: None Fixes cockroachdb#86752
aliher1911
force-pushed
the
clear_range_range_tombstone_gc
branch
from
00962cc to
e6a121b
Compare
|
bors r=erikgrinaker |
|
Build failed: |
|
bors r=erikgrinaker |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously clear range tests were run with default server settings. Range tombstones are disabled by default so new functionality in schema change commands is not execised. This commit adds test variant that enables range tombstones.
Release note: None
Fixes #86752