kvnemesis: use execution timestamp from ambiguous errors #88722
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
tbg
force-pushed
the
ambiguous-candidate-timestamps
branch
from
2b9161b to
c875758
Compare
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
Sep 26, 2022
This is possible now, thanks to cockroachdb#88722. Closes cockroachdb#69642. Release note: None
Now whenever data actually made it to KV (ambiguously or not) we know the timestamp at which this has happened. We can thus remove much of the special-casing around deletions. In particular, we no longer need to consider half-materialized writes, i.e. the case `Materialized=true && Timestamp.IsEmpty()`. In turn, we get to remove the `Materialized` field altogether, as it now always equals `Timestamp.IsSet()`. This then removes all special casing around deletions. They are still keyed by key and timestamp as opposed to by value (since they have no value) but other than that they get treated the same. Release note: None
tbg
force-pushed
the
ambiguous-candidate-timestamps
branch
from
c875758 to
ee8de81
Compare
|
Big rework coming in a day or two. |
|
"a day or two" Well here it is #89477 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now whenever data actually made it to KV (ambiguously or not) we know
the timestamp at which this has happened.
We can thus remove much of the special-casing around deletions. In
particular, we no longer need to consider half-materialized writes,
i.e. the case
Materialized=true && Timestamp.IsEmpty(). In turn,we get to remove the
Materializedfield altogether, as it nowalways equals
Timestamp.IsSet(). This then removes all specialcasing around deletions. They are still keyed by key and timestamp
as opposed to by value (since they have no value) but other than
that they get treated the same.
Release note: None