Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: fix flaky test for consistency checks #88449

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

pav-kv
Copy link
Collaborator

@pav-kv pav-kv commented Sep 22, 2022

There was a race in selecting between a canceled context.Done and 0-time timer.

Fixes #88133

Release justification: flaky test fix
Release note: None

There was a race in selecting between a canceled context.Done and 0-time timer.

Release justification: flaky test fix
Release note: None
@pav-kv pav-kv requested a review from erikgrinaker September 22, 2022 11:32
@pav-kv pav-kv requested a review from a team as a code owner September 22, 2022 11:32
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@pav-kv pav-kv requested review from tbg and removed request for erikgrinaker September 22, 2022 11:35
@pav-kv
Copy link
Collaborator Author

pav-kv commented Sep 22, 2022

bors r=erikgrinaker

@craig
Copy link
Contributor

craig bot commented Sep 22, 2022

Build succeeded:

@craig craig bot merged commit 7278468 into cockroachdb:master Sep 22, 2022
@pav-kv pav-kv deleted the fix_flake branch September 22, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kvserver: flake in TestGetChecksumNotSuccessfulExitConditions
3 participants